Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMARA ICM-examples #148

Merged
merged 26 commits into from
Jun 4, 2024
Merged

CAMARA ICM-examples #148

merged 26 commits into from
Jun 4, 2024

Conversation

AxelNennker
Copy link
Collaborator

Move CAMARA-ICM-examples.md from fork to this repo

@jpengar jpengar added the v0.2-candidate Custom label for issues that are candidates to be fixed in v0.2 (if needed) label May 8, 2024
@jpengar jpengar mentioned this pull request May 8, 2024
Copy link
Collaborator

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have deliberately took any details about how CAMARA might use authorization_details in future out of the profile.

I propose to also omit the examples from this file here (which will go into the v0.2 release).

Why? We would otherwise need to discuss and decide about the examples now, as it could otherwise be that people start to implement it this way. For example we haven't decided if authorization_details will be used if there is only one purpose (we envision RAR for more complex scenarios). Within the examples for multiple purposes I have the impression that the use of "locations" isn't as intended in the RFC, but that's a discussion which doesn't belong here and now, as we need first to define which scenarios we want to cover business wise.

AxelNennker and others added 4 commits May 22, 2024 13:59
Co-authored-by: Ming Hui <134043190+mhfoo@users.noreply.github.com>
Co-authored-by: Ming Hui <134043190+mhfoo@users.noreply.github.com>
Co-authored-by: Elisabeth-Ericsson <121795930+Elisabeth-Ericsson@users.noreply.github.com>
Co-authored-by: Ming Hui <134043190+mhfoo@users.noreply.github.com>
@shilpa-padgaonkar shilpa-padgaonkar self-requested a review May 29, 2024 14:55
@AxelNennker
Copy link
Collaborator Author

I think the examples document looks quite good. @hdamker is back on Monday and I assume that his change request was about removing the RAR examples. Not sure why github did not mark that change request as "outdated". Anyway, waiting for Herbert to confirm and approve.

@Elisabeth-Ericsson and @mhfoo do you need further changes, more examples or would you please approve this PR?

Co-authored-by: Shilpa Padgaonkar <77152136+shilpa-padgaonkar@users.noreply.github.com>
Copy link
Collaborator

@shilpa-padgaonkar shilpa-padgaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

documentation/CAMARA-ICM-examples.md Outdated Show resolved Hide resolved
documentation/CAMARA-ICM-examples.md Outdated Show resolved Hide resolved
AxelNennker and others added 2 commits May 31, 2024 16:50
Co-authored-by: Shilpa Padgaonkar <77152136+shilpa-padgaonkar@users.noreply.github.com>
@AxelNennker AxelNennker changed the title WIP: CAMARA ICM-examples CAMARA ICM-examples May 31, 2024
@AxelNennker
Copy link
Collaborator Author

I have the impression that this PR is about to be finished. So, I removed the WIP.

@AxelNennker
Copy link
Collaborator Author

@jpengar @sebdewet do you approve this PR?

@hdamker
Copy link
Collaborator

hdamker commented Jun 2, 2024

@AxelNennker

... I assume that his change request was about removing the RAR examples. Not sure why github did not mark that change request as "outdated". Anyway, waiting for Herbert to confirm and approve.

Your assumption is correct, my request is addressed with the removal of the RAR examples.

hdamker
hdamker previously approved these changes Jun 2, 2024
Copy link
Collaborator

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, requested changes are addressed.

Co-authored-by: Jesús Peña García-Oliva <jesus.penagarcia-oliva@telefonica.com>
Copy link
Collaborator

@jpengar jpengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AxelNennker AxelNennker merged commit 2e51443 into main Jun 4, 2024
@jpengar jpengar deleted the icm_examples branch August 29, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v0.2-candidate Custom label for issues that are candidates to be fixed in v0.2 (if needed)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants